gh-142916: fix mkdir TOCTOU race condition #143162
Closed
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misc/NEWS.d/next/Library/2025-12-25-13-51-06.gh-issue-142916.gm4EzD.rst
Outdated
Show resolved
Hide resolved
|
This PR doesn't actually fix the race condition; it makes the race window smaller but doesn't eliminate it. The retry adds extra syscalls in the error path with no clear benefit since it doesn't eliminate the race. The same failure mode can still occur:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix mkdir TOCTOU race condition
pathlib.Path.mkdir()raisesFileExistsErrorfor non-existent path due to TOCTOU race condition #142916